Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files

org/cb/cardboard/AbstractCardBoardModel.java

Error		Line
	First sentence should end with a period.	57
	Line is longer than 100 characters.	68
	First sentence should end with a period.	74
	Line is longer than 100 characters.	85
	First sentence should end with a period.	91
	Line is longer than 100 characters.	102

org/cb/cardboard/BoardSelectionModel.java

Error		Line
	Expected @param tag for 'index'.	116
	Expected an @return tag.	152
	Unclosed HTML tag found: <code>true<code> if no indices are selected.	170
	Expected @param tag for 'index'.	179
	Expected @param tag for 'length'.	179
	Expected @param tag for 'before'.	179
	Expected @param tag for 'index0'.	186
	Expected @param tag for 'index1'.	186

org/cb/cardboard/DefaultBoardSelectionModel.java

Error		Line
	Using the '.*' form of import should be avoided - javax.swing.*.	22
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	55
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	80
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	95
	Missing a Javadoc comment.	100
	Missing a Javadoc comment.	105
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	115
	Missing a Javadoc comment.	120
	Missing a Javadoc comment.	125
	Missing a Javadoc comment.	130
	Missing a Javadoc comment.	135

org/cb/jset/BoardImpl.java

Error		Line
	Parameter boardListener should be final.	64
	Unable to get class information for MatchingException.	96
	Unable to get class information for BoardException.	96
	Line is longer than 100 characters.	112
	Line is longer than 100 characters.	137
	Line is longer than 100 characters.	149

org/cb/jset/CardProperties.java

Error		Line
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	51
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	55
	Expected @param tag for 'card'.	172
	'if' construct must use '{}'s.	213
	'if' construct must use '{}'s.	214
	'if' construct must use '{}'s.	218
	'if' construct must use '{}'s.	219
	'if' construct must use '{}'s.	220
	'if' construct must use '{}'s.	221

org/cb/jset/CardSet.java

Error		Line
	'&&' should be on a new line.	63
	'&&' should be on a new line.	65
	'&&' should be on a new line.	70
	'&&' should be on a new line.	72
	'&&' should be on a new line.	77
	'&&' should be on a new line.	79
	'&&' should be on a new line.	84
	'&&' should be on a new line.	86
	Line has trailing spaces.	105
	Expected @param tag for 'args'.	108

org/cb/jset/CardStack.java

Error		Line
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	39
	Expression can be simplified.	47
	Line is longer than 100 characters.	57
	Missing a Javadoc comment.	62
	Missing a Javadoc comment.	72
	Missing a Javadoc comment.	77

org/cb/jset/JSetBuild.java

Error		Line
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31

org/cb/jset/JSetCard.java

Error		Line
	Line has trailing spaces.	29
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	43
	Missing a Javadoc comment.	58
	'if' construct must use '{}'s.	60
	'if' construct must use '{}'s.	61
	'if' construct must use '{}'s.	65
	Missing a Javadoc comment.	70
	Line is longer than 100 characters.	96
	Missing a Javadoc comment.	102

org/cb/jset/JSetGameImpl.java

Error		Line
	Line is longer than 100 characters.	110
	Line is longer than 100 characters.	122
	Line is longer than 100 characters.	164
	First sentence should end with a period.	229
	Expected @param tag for 'player'.	232
	Missing a Javadoc comment.	240
	Missing a Javadoc comment.	245
	Unable to get class information for MatchingException.	245
	'catch' is not followed by whitespace.	262
	Missing a Javadoc comment.	271
	Missing a Javadoc comment.	278
	Missing a Javadoc comment.	284
	Line is longer than 100 characters.	306
	Missing a Javadoc comment.	312
	Missing a Javadoc comment.	317
	Missing a Javadoc comment.	346
	Missing a Javadoc comment.	367
	Missing a Javadoc comment.	369
	Line contains a tab character.	378
	Line contains a tab character.	379
	Line contains a tab character.	380
	Line contains a tab character.	381
	Line contains a tab character.	382
	'&&' should be on a new line.	390
	Missing a Javadoc comment.	425
	Missing a Javadoc comment.	432
	Missing a Javadoc comment.	437
	Missing a Javadoc comment.	442
	Missing a Javadoc comment.	457
	Missing a Javadoc comment.	462
	Missing a Javadoc comment.	472
	Must have at least one statement.	494
	Missing a Javadoc comment.	517
	'+' should be on a new line.	552
	Unable to get class information for MatchingException.	558
	Unable to get class information for BoardException.	558
	Missing a Javadoc comment.	572
	Missing a Javadoc comment.	584
	Missing a Javadoc comment.	589
	Missing a Javadoc comment.	594
	Missing a Javadoc comment.	599
	Missing a Javadoc comment.	618
	Missing a Javadoc comment.	623
	Missing a Javadoc comment.	628

org/cb/jset/MatchingException.java

Error		Line
	Line has trailing spaces.	24

org/cb/jset/SetGame.java

Error		Line
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	36
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	40

org/cb/jset/SetGameBoard.java

Error		Line
	Unable to get class information for MatchingException.	52
	Unable to get class information for BoardException.	52

org/cb/jset/SetGameConnection.java

Error		Line
	Line is longer than 100 characters.	25
	Unable to get class information for MatchingException.	38

org/cb/jset/SetGamePlayer.java

Error		Line
	Line has trailing spaces.	51

org/cb/jset/client/AbstractGame.java

Error		Line
	Line has trailing spaces.	29
	Missing a Javadoc comment.	36
	Variable '_listenerList' must be private and have accessor methods.	36
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	49
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	90

org/cb/jset/client/Client.java

Error		Line
	Utility classes should not have a public or default constructor.	46
	Line is longer than 100 characters.	50
	Missing a Javadoc comment.	50
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	60
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	70
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	80
	Missing a Javadoc comment.	85
	Missing a Javadoc comment.	90
	Missing a Javadoc comment.	96
	Missing a Javadoc comment.	102
	Missing a Javadoc comment.	109
	Missing a Javadoc comment.	114
	Unable to get class information for MatchingException.	114
	Missing a Javadoc comment.	126
	Missing a Javadoc comment.	138
	Missing a Javadoc comment.	153
	Missing a Javadoc comment.	159
	Missing a Javadoc comment.	166
	Missing a Javadoc comment.	171
	Missing a Javadoc comment.	184
	Missing a Javadoc comment.	197
	Missing a Javadoc comment.	202
	Missing a Javadoc comment.	216
	Missing a Javadoc comment.	229
	Missing a Javadoc comment.	244
	switch without "default" clause.	251
	Missing a Javadoc comment.	283
	Line is longer than 100 characters.	307

org/cb/jset/client/LocalGame.java

Error		Line
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	54
	Missing a Javadoc comment.	59
	Missing a Javadoc comment.	64
	First sentence should end with a period.	118
	Expected @param tag for 'cards'.	121
	First sentence should end with a period.	126
	Expected @param tag for 'set'.	129
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	140
	Missing a Javadoc comment.	145
	Unable to get class information for MatchingException.	145

org/cb/jset/client/NetworkGame.java

Error		Line
	First sentence should end with a period.	36
	Missing a Javadoc comment.	53
	Missing a Javadoc comment.	58
	'final' modifier out of order with the JLS suggestions.	63
	Missing a Javadoc comment.	65
	Missing a Javadoc comment.	71
	Missing a Javadoc comment.	76
	Missing a Javadoc comment.	82
	Missing a Javadoc comment.	88
	Line is longer than 100 characters.	90
	Missing a Javadoc comment.	93
	Missing a Javadoc comment.	98
	Missing a Javadoc comment.	104
	Missing a Javadoc comment.	110
	Missing a Javadoc comment.	130
	Missing a Javadoc comment.	135
	Missing a Javadoc comment.	151
	Missing a Javadoc comment.	157
	Missing a Javadoc comment.	162
	Missing a Javadoc comment.	175
	Missing a Javadoc comment.	180
	Unable to get class information for MatchingException.	180
	Line contains a tab character.	198
	Missing a Javadoc comment.	214
	'!' is followed by whitespace.	221
	Must have at least one statement.	234
	Missing a Javadoc comment.	244
	Line is longer than 100 characters.	306

org/cb/jset/client/SetGame.java

Error		Line
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Unable to get class information for MatchingException.	41
	Missing a Javadoc comment.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	48
	Missing a Javadoc comment.	49

org/cb/jset/client/SetGameListener.java

Error		Line
	Line has trailing spaces.	33
	Expected @param tag for 'event'.	36

org/cb/jset/client/SmartAutoPlayer.java

Error		Line
	Using the '.*' form of import should be avoided - org.cb.jset.*.	23
	Expected @param tag for 'playerName'.	49
	Missing a Javadoc comment.	57
	Missing a Javadoc comment.	72
	Line has trailing spaces.	86
	First sentence should end with a period.	91
	Expected @param tag for 'cards'.	94
	First sentence should end with a period.	99
	Expected @param tag for 'set'.	102
	First sentence should end with a period.	114
	Expected @param tag for 'event'.	117
	Missing a Javadoc comment.	124
	Missing a Javadoc comment.	132
	Missing a Javadoc comment.	134
	'!' is followed by whitespace.	142
	Missing a Javadoc comment.	148
	'catch' is not followed by whitespace.	166
	Must have at least one statement.	167
	'.' is followed by whitespace.	175
	Must have at least one statement.	178
	Missing a Javadoc comment.	233

org/cb/jset/client/model/CardEvent.java

Error		Line
	Line has trailing spaces.	42
	Expected @param tag for 'source'.	46
	Expected @param tag for 'type'.	46

org/cb/jset/client/model/JSetClientBoardModel.java

Error		Line
	Line is longer than 100 characters.	38
	Line is longer than 100 characters.	45
	'final' modifier out of order with the JLS suggestions.	47
	Line is longer than 100 characters.	75
	Expected @param tag for 'index'.	77
	Line is longer than 100 characters.	83
	Line is longer than 100 characters.	111
	Unable to get class information for BoardException.	161
	Line is longer than 100 characters.	206
	Line is longer than 100 characters.	212
	Line has trailing spaces.	230

org/cb/jset/client/model/SetGameClientBoard.java

Error		Line
	Line is longer than 100 characters.	41
	Unable to get class information for BoardException.	49

org/cb/jset/client/ui/JSetBoardComponent.java

Error		Line
	Line has trailing spaces.	146

org/cb/jset/client/ui/JSetCardComponent.java

Error		Line
	Line is longer than 100 characters.	91
	Expected @param tag for 'bounds'.	95
	Line is longer than 100 characters.	153
	First sentence should end with a period.	181
	Expected @param tag for 'g'.	184
	Line is longer than 100 characters.	187
	switch without "default" clause.	196
	',' is not followed by whitespace.	209
	',' is not followed by whitespace.	209
	',' is not followed by whitespace.	209
	switch without "default" clause.	215
	switch without "default" clause.	231
	Line is longer than 100 characters.	259
	Line is longer than 100 characters.	280
	Line is longer than 100 characters.	286
	Line is longer than 100 characters.	295
	Expected @param tag for 'card'.	308
	Line is longer than 100 characters.	359
	Line is longer than 100 characters.	365
	Line is longer than 100 characters.	370
	Line is longer than 100 characters.	372
	Line is longer than 100 characters.	396
	First sentence should end with a period.	428
	'!' is followed by whitespace.	433
	Avoid inline conditionals.	448
	Expected @param tag for 'g'.	473
	Line is longer than 100 characters.	476
	Parameter i should be final.	485
	Expected @param tag for 'i'.	485
	Line is longer than 100 characters.	491
	First sentence should end with a period.	495
	Line contains a tab character.	502
	'if' is not followed by whitespace.	502
	Expected @param tag for 'cardListener'.	513
	Expected @param tag for 'cardListener'.	522
	First sentence should end with a period.	527

org/cb/jset/client/ui/JSetClientUI.java

Error		Line
	Missing a Javadoc comment.	80
	Variable '_logger' must be private and have accessor methods.	80
	Redundant throws: 'HeadlessException' is unchecked exception.	107
	Line is longer than 100 characters.	123
	Line is longer than 100 characters.	135
	Parameter e should be final.	224
	Missing a Javadoc comment.	284
	Missing a Javadoc comment.	322
	Line is longer than 100 characters.	325
	Missing a Javadoc comment.	334
	Line is longer than 100 characters.	337
	Missing a Javadoc comment.	346
	Missing a Javadoc comment.	368
	First sentence should end with a period.	410
	Expected @param tag for 'cards'.	413
	First sentence should end with a period.	418
	Expected @param tag for 'set'.	421
	First sentence should end with a period.	426
	Expected @param tag for 'event'.	429
	Line is longer than 100 characters.	480
	Missing a Javadoc comment.	544
	Missing a Javadoc comment.	546
	Missing a Javadoc comment.	569

org/cb/jset/server/JSetRemoteGameImpl.java

Error		Line
	Line is longer than 100 characters.	37
	Expected @param tag for 'name'.	54
	Expected @param tag for 'nbPlayers'.	54
	Line is longer than 100 characters.	64
	First sentence should end with a period.	68
	Expected @param tag for 'localConnection'.	73
	Unable to get class information for MatchingException.	84
	Expected @param tag for 'remotePlayer'.	123
	Missing a Javadoc comment.	250
	Missing a Javadoc comment.	255
	First sentence should end with a period.	260
	Expected an @return tag.	263
	Expected @throws tag for 'RemoteException'.	263
	First sentence should end with a period.	268
	Expected an @return tag.	271
	Expected @throws tag for 'RemoteException'.	271
	First sentence should end with a period.	276
	Expected an @return tag.	279
	Expected @throws tag for 'RemoteException'.	279
	First sentence should end with a period.	284
	Expected an @return tag.	287
	Expected @param tag for 'player'.	287
	Expected @throws tag for 'RemoteException'.	287
	First sentence should end with a period.	302
	Expected an @return tag.	305
	Expected @throws tag for 'RemoteException'.	305

org/cb/jset/server/RemoteSetGameConnection.java

Error		Line
	Unable to get class information for MatchingException.	43